Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature doc template #4355

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

tssurya
Copy link
Member

@tssurya tssurya commented May 14, 2024

What this PR does and why is it needed

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?


@tssurya tssurya requested a review from a team as a code owner May 14, 2024 09:07
@tssurya tssurya requested a review from kyrtapz May 14, 2024 09:07
@tssurya tssurya force-pushed the add-feature-doc-template branch 2 times, most recently from 4e0149e to e039657 Compare May 14, 2024 09:09
@coveralls
Copy link

Coverage Status

Changes unknown
when pulling e039657 on tssurya:add-feature-doc-template
into ** on ovn-org:master**.

@tssurya tssurya added the kind/documentation All issues related to documentation label May 14, 2024
docs/features/template.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kyrtapz kyrtapz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!
Do you think it would be worth to add a section about dependencies and something about whether the feature in question affects other features?

docs/features/template.md Outdated Show resolved Hide resolved
docs/features/template.md Outdated Show resolved Hide resolved
docs/features/template.md Outdated Show resolved Hide resolved
@tssurya tssurya force-pushed the add-feature-doc-template branch 2 times, most recently from d130532 to ee5cb96 Compare May 17, 2024 15:59
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya tssurya merged commit 994bbc6 into ovn-org:master May 20, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation All issues related to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants