Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creating and binding port for logical router task #132

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

huikang
Copy link
Collaborator

@huikang huikang commented Sep 21, 2016

  • this is a follow-up task for create_routers tasks
  • create and bind ports for logical switches, which connect
    to the logical routers

Signed-off-by: Hui Kang kangh@us.ibm.com

- this is a follow-up task for create_routers tasks
- create and bind ports for logical switches, which connect
  to the logical routers

Signed-off-by: Hui Kang <kangh@us.ibm.com>
Copy link
Collaborator

@hzhou8 hzhou8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just noticed that an update is needed in _create_networks() because now we are introducing lrouters in the tests, but not related to this patch. I create an issue to track #134

@huikang
Copy link
Collaborator Author

huikang commented Sep 23, 2016

@mestery when you are free, could you review this PR? Thanks.

@mestery
Copy link
Collaborator

mestery commented Sep 29, 2016

LGTM, thanks @huikang!

@mestery mestery merged commit 046543c into ovn-org:master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants