Version mismatch "not loading" error appears for disabled mods

[xen-42]

Get a log error saying

Not loading Raicuparta.QuantumSpaceBuddies, as the current game version 1.1.14.768 is different to the latest version 1.1.13.456

Even though QSB is disabled.

[misternebula]

this shouldnt be possible?

var shouldLoad = _modVersionChecker.CheckModVersion(modData) && _modVersionChecker.CheckModGameVersion(modData, latestGameVersion);

method that prints those errors is CheckModGameVersion, and CheckModVersion will return false if a mod is disabled

[xen-42]

No, that method returns true if a mod is disabled. That was changed to fix #369 where it would log errors about versions for disabled mods.

[xen-42]

Could've fixed both issues by doing this instead
var shouldLoad = modData.Config.Enabled && _modVersionChecker.CheckModVersion(modData) && _modVersionChecker.CheckModGameVersion(modData, latestGameVersion);
Otherwise its only in LoadMod (line 141) that it decides to ignore disabled mods