PopupInput fixes #404
Merged
PopupInput fixes #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazingalek
reviewed
Nov 3, 2021
amazingalek
reviewed
Nov 3, 2021
amazingalek
reviewed
Nov 3, 2021
| private void OnTabOpen(IModTabMenu tabMenu) | ||
| { | ||
| var selectablesStack = MenuStackManager.SharedInstance.GetValue<Stack<Selectable>>("_lastSelectedStack"); | ||
| if ((selectablesStack.Count + _menuStackCount) == MenuStackManager.SharedInstance.GetMenuCount()) |
There was a problem hiding this comment.
maybe >= just in case?
There was a problem hiding this comment.
Actually, it would be ≤ then
amazingalek
approved these changes
Nov 3, 2021
Raicuparta
added a commit
that referenced
this pull request
Nov 13, 2021
* fixed asset colors * 2.0.1 * fixed exiting from OWML config menu with button press (#371) * Allow external patchers to execute before the game (#370) * Added support for external patchers declared in the manifest * Fixed typo * Only check for patcher parameter * Fixed identation * again... * Removed useless check Co-authored-by: Ricardo <Raicuparta@users.noreply.github.com> * ModsMenu fixes (#374) (#375) * Cancel now also saves, properly unsubscribe events when scene changes * Conform to repo's code style * Remove useless cleanup logic Co-authored-by: artum <jacopo.libe@gmail.com> * 2.1.0 (#376) * Remove RequireVR (#378) * patcher cleanup (#379) * patcher cleanup * cleanup * cleanup * Select first fix (#380) * fixed SelectFirstOnActivate in OWML menus and tweaked nav generation * Fixed issue with selector, text, and number inputs (#389) * Better tab nav (#382) * Run game through epic launcher / steam (#381) * Remove redundant description (#386) No longer used anywhere * Fixes Issue#390: Controller Overriding Input Values (#392) * Fix Text Input * Fix number input * Adding separators as mod settings, to make large configurations easier to parse (#393) * Added deeper menus for text and number inputs (#394) * Merge + cleanup (#396) * fix manifest versions * Prevent warning on minor version difference * Option to launch through exe (#402) * remove test unpatching in sample mod * update sample mods' owml version * add forceExe option to owml config * use forceExe config to force running through exe * PopupInput fixes (#404) * first batch (still doesn't reopen the correct menu and has a bunch of debug lines) * exiting InputPopup now seems to return to it's ModConfig tab correctly * fixfixfix (something something pause menu) * removed stray tabs * removed comments * Scrollable modconfigmenus (#406) * added names to added gameObjects (#407) * modmenus names * also a main/pause menu MODS button * Always save when exiting (#408) * Update ModMenu.cs (#405) Some minor refactoring to make it more obvious what is happening. * added null mod check (#409) Co-authored-by: Aleksandr <TAImatem@gmail.com> Co-authored-by: artum <jacopo.libe@gmail.com> Co-authored-by: Ricardo <Raicuparta@users.noreply.github.com> Co-authored-by: Joseph <salomj9@gmail.com> Co-authored-by: _nebula <41904486+misternebula@users.noreply.github.com> Co-authored-by: Raicuparta <raicuparta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popup input seems to work correctly now (not block mouse input, come back to Mod Config Menu when closed), although opening it from pause menu is broken now smh