Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add version flag #122

Merged
merged 2 commits into from
Sep 15, 2023
Merged

feat: add version flag #122

merged 2 commits into from
Sep 15, 2023

Conversation

algomaster99
Copy link
Contributor

Fixes #121

I have added the function for getting the version. Could you point in the code where do I need to edit the metadata?

@prabhu
Copy link
Member

prabhu commented Sep 11, 2023

Wow, this is super fast!!!

We can update the metadata here.

https://github.com/owasp-dep-scan/dep-scan/blob/master/depscan/cli.py#L386

@algomaster99 algomaster99 marked this pull request as ready for review September 11, 2023 12:11
@algomaster99
Copy link
Contributor Author

@prabhu done!

Two things need to be done:

  1. Update test resources
  2. Add pURL and other attributes as listed here.

@prabhu
Copy link
Member

prabhu commented Sep 11, 2023

Thank you so much. @cerrussell, could you kindly take a look?

@cerrussell
Copy link
Collaborator

@prabhu Looks good to me, thanks @algomaster99 !

@cerrussell cerrussell merged commit 300ae6b into owasp-dep-scan:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cerrussell cerrussell cerrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version of depscan
3 participants
@algomaster99 @prabhu @cerrussell