This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Correction of a bug in the documentation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case must be considered as two separate conditions. It is not possible to check if the value is present only in the "new values" array, because during the record 'created' event, "role_id" will not appear in the "old values" array yet, so we will get ErrorException "Trying to get property 'role_id' of non-object ". I think that it would also be worth considering one place where we could define what values from the array in each instance should be converted into what values provided by us. :)
write-programmer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case must be considered as two separate conditions. It is not possible to check if the value is present only in the "new values" array, because during the record 'created' event, "role_id" will not appear in the "old values" array yet, so we will get ErrorException "Trying to get property 'role_id' of non-object ". I think that it would also be worth considering one place where we could define what values from the array in each instance should be converted into what values provided by us. :)