getAuditableEvents() return cofig #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least add a description to this PR. Didn't you open a ticket about this? Mention this solves it. Also, where's the updated audit configuration? You basically had to copy and paste my earlier comment. |
|
I am sorry am new to github this is my first Pull request |
|
Sure mate, just update your PR and we'll merge this. |
|
Mate, you don't have to close this PR. Just commit the |
quetzyg
suggested changes
Nov 14, 2017
config/audit.php
Outdated
| @@ -78,4 +78,20 @@ | |||
| */ | |||
|
|
|||
| 'console' => false, | |||
|
|
|||
There was a problem hiding this comment.
It was supposed to go after the 'user' stuff, but fuck it, I'll fix it later.
quetzyg
reviewed
Nov 14, 2017
config/audit.php
Outdated
| @@ -92,6 +92,6 @@ | |||
| 'created', | |||
| 'updated', | |||
| 'deleted', | |||
| 'restored', | |||
There was a problem hiding this comment.
You still have a white space, dude.
quetzyg
approved these changes
Nov 14, 2017
|
Nicely done @vyacheslav-kara. You'll get the hang of it 😉 |
|
Хahaha thanks that was hard formatting 😄 Now I go to celebrate my first PR 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.