Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix chart revisions for edge cases #2069

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

Marigold
Copy link
Collaborator

There were two issues with chart revisions:

  1. Some charts don't have config["id"] - Hotfixed by creating it when loading the chart, but the plan is to fix all charts like that in MySQL
  2. Some suggested revisions don't have version - this was caused by function that was deleting properties with default values (where version = 1) even though the property is required

I've tested it locally. If you run into an error that says chart revisions don't have a unique chartId, you'll have to delete that revision manually from DB (this happens because of previous failed attempts).

Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this, looks good!

@Marigold Marigold merged commit bea3e71 into master Dec 12, 2023
18 checks passed
@Marigold Marigold deleted the fix-chart-revisions branch December 12, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants