Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scverse integration #15

Closed
grst opened this issue Dec 21, 2022 · 4 comments · Fixed by scverse/ecosystem-packages#79
Closed

scverse integration #15

grst opened this issue Dec 21, 2022 · 4 comments · Fixed by scverse/ecosystem-packages#79

Comments

@grst
Copy link

grst commented Dec 21, 2022

Hi,

congrats on the launch of PyDESeq2 -- I've been waiting for that for ages.

I'm a core developer of scverse, and we want to foster interoperability of python packages for (not only single-cell) omics data analysis. I was wondering if you would be interested in integrating PyDESeq2 with our ecosystem. This would greatly streamline leveraging PyDESeq2 for (pseudo-bulk) single-cell analysis for many users.

What would you be required to do?

We have a checklist for becoming an ecosystem package mostly related to software quality. I believe you tick most of it already.

The only important point would be to use our AnnData datastructure. AnnData is the Python equivalent of Bioconductor's SummarizedExperiment, and allows to store a gene expression matrix (X) together with sample metadata (obs) and variable metadata (var) in a single object. It also allows to store unstructured information (uns) (e.g. the design factor), or DE results in as a data frame aligned to variables (varm). AnnData objects can be serialized to disk (h5/zarr) and are easy to share.

At the very least, you'd need to support this in addition to counts_df/clinical_df, but it could even make sense to switch to AnnData internally.

What do you gain?

  • Interoperability with scverse tools and potentially a larger user base.
  • Be recognized on the scverse website as approved ecosystem tool
  • We offer a best-practice cookiecutter template which would also help you get started on a readthedocs documentation website (Add documentation #7).
  • You can use our discourse forum as a channel to provide user support

Let me know what you think!
Best,
Gregor

@BorisMuzellec
Copy link
Collaborator

BorisMuzellec commented Dec 22, 2022

Hi Gregor,

Thanks a lot, we're very excited by this idea (and we were actually secretly considering using AnnData at some point anyway :) ).

Right now we have some more pressing points to deal with (e.g. building documentation and enjoying Christmas holidays), but we're happy to start working on the integration after that.

Let's stay in touch!

Best,
Boris

@grst
Copy link
Author

grst commented Dec 22, 2022

Hi Boris,

sounds great, looking forward!
You can also talk to us on the scverse zulip chat if you have any questions!

Wish you nice holidays,
Gregor

@grst
Copy link
Author

grst commented Jan 5, 2023

I would like to highlight again the scverse cookiecutter template: https://github.com/scverse/cookiecutter-scverse (It might have gotten lost in the previous message).

It's fair enough if you don't want to switch to the template anymore at this stage, but it would get you a bunch of things for free that you are currently working on, e.g. code coverage, notebook examples (plus additional pre-commit checks and pure pyproject.toml-based build system)

@BorisMuzellec
Copy link
Collaborator

Hi Gregor, thanks for the suggestion. Not sure that we'll switch to the cookiecutter template entirely but we've had a look at it and we plan to draw inspiration from it indeed :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants