BUG Fix new all zero replace #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisMuzellec
requested review from
maikia and
arthurPignetOwkin
as code owners
umarteauowkin
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #237, closes #238
What does your PR implement? Be specific.
This PR fixes a bug arising when all genes whose Cooks outliers are replaced lead to all-zero values (cf #237).
To fix this, it introduces (similarly to DESeq2) a new
varmfield,"refitted", which complements"replaced"by indicating whether dispersions and LFCs were refitted for that gene (on top of its having values replaced).Finally, the faulty example presented in #237 was added to the test suite.