Fix Inference n_cpus overwritten issue #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihming
requested review from
BorisMuzellec,
maikia and
arthurPignetOwkin
as code owners
yihming
changed the title
umarteauowkin
approved these changes
Jun 13, 2024
|
Thanks a lot @yihming :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
This PR is to fix Issue #288 .
What does your PR implement? Be specific.
The current initialization of
DeseqDataSetalways overwrites itsInferenceobject'sn_cpus. So no matter which value is specified forn_cpuswhen declaring anInferenceobject, when passed toDeseqDataSet, itsn_cpusis always overwritten to use all available vCPUs.My implementation just restricts that Inference's
n_cpuscan only be overwritten if DeseqDataSet'sn_cpusis notNone.