Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise examples #672

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Revise examples #672

merged 6 commits into from
Jul 3, 2024

Conversation

jzstark
Copy link
Collaborator

@jzstark jzstark commented Jul 1, 2024

Keep examples up-to-date with current version of Owl/OCaml, and also update all existing datasets used in examples.

@ryanrhymes ryanrhymes self-requested a review July 2, 2024 14:50
Copy link
Member

@ryanrhymes ryanrhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! Tested on my laptop and all the examles run well with the fixed dataset repo. Great job!

@@ -1 +0,0 @@
The examples in this folder are made based on the OCaml's toplevel and Owl's Zoo system. Please refer to [Tutorial 9: Scripting and Zoo System](https://github.com/ryanrhymes/owl/wiki/Tutorial:-Scripting-and-Zoo-System).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep the file, adding a couple of lines on how to run the examples? There is no dune file in the folder, so a priori is not obvious for a new user what to do now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There is actually a dune file added to this folder, and I've updated the readme file accordingly.

@jzstark jzstark merged commit 455bde1 into main Jul 3, 2024
26 checks passed
@jzstark jzstark deleted the test branch July 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants