updated asm to version 7 and some other libs too #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damnms
commented
Oct 5, 2018
| requires java.xml.bind; | ||
| requires jersey.common; | ||
| requires java.json; | ||
| requires java.sql; |
There was a problem hiding this comment.
this can be ignored, its a real mess to work with java ee libraries in java9+ modules
|
just started a jeromq server and client with java11 and can confirm it works - but its more a hack than a real PR, hope you can work with that |
damnms
commented
Oct 5, 2018
| @@ -53,6 +53,11 @@ public JsonGenerator writeStartObject(String name) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public JsonGenerator writeKey(String s) { | |||
| return this; | |||
There was a problem hiding this comment.
this is just a hack to get it working with the compiler - needs a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not a finished PR, i had no time to fix the maven-bundle-plugin. also updated some of the other deps too