-
Notifications
You must be signed in to change notification settings - Fork 168
Revise source installation guide for the upgrade to PHP 7.2 #4422
Conversation
@@ -354,15 +334,15 @@ Required Extensions | |||
|
|||
:: | |||
|
|||
zypper install apache2 apache2-mod_php5 php5-gd php5-json php5-curl \ | |||
php5-intl php5-mcrypt php5-zip php5-zlib | |||
zypper install -y apache2 apache2-mod_php7 php7-gd \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please double check if there is a package called php7-openssl. we had a report about this with opensuse owncloud/core#30337
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. There most certainly is. I'll update this section of the docs to include it.
a5d442e
to
d04883e
Compare
@DeepDiver1975, amended the SLES commands to install |
php7.0-imap php7.0-intl php7.0-json php7.0-ldap php7.0-mbstring \ | ||
php7.0-mcrypt php7.0-mysql php7.0-pgsql php-smbclient php-ssh2 \ | ||
php7.0-sqlite3 php7.0-xml php7.0-zip | ||
apt-get install -y apache2 mariadb-server libapache2-mod-php7.2 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an Ubuntu 16.04 system any more, but to get PHP 7.2 on that, I think you will have to install ppa:ondrej/php - Ubuntu 16.04 comes with some default PHP version. Did it come with PHP 7.0?
But the section heading could be changed to Ubuntu 18.04, which comes with PHP 7.2. And these commands should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone on Ubuntu 16.04 has to anyway, by the end of the year, either "manually" install some later PHP or upgrade to Ubuntu 18.04
This is the challenge when providing explicit instruction for different *nix distros. Which PHP version came standard in which version of which distro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info. As best I remember, the Docker container I'm using for the Ubuntu 16.04 image didn't need that repo. I'll rebuild it from scratch and check.
Without this step, on a fresh Ubuntu installation, PHP 7.2 won't be available.
@phil-davis, just made a further, small, update to add the PPA repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me. I only know detail about Ubuntu. My comments about that are:
- In production, people might be reticent to add
ppa:ondrej/php
in order to install PHP 7.2 on Ubuntu 16.04 - but if you want PHP 7.2 without upgrading to Ubuntu 18.04, then that is the way to get it. - We could add a section for Ubuntu 18.04. That will get you PHP 7.2 "for free". That can be added in a next PR.
I'll merge this now as is - we can cycle to improve .... |
@phil-davis, well said. I'll get the Ubuntu 18.04 additions made. |
This updates the documentation to set PHP 7.2 as the minimum (recommended) version of PHP from the original documentation. Specifically, it backports: - owncloud-archive/documentation#4416 - owncloud-archive/documentation#4420 - owncloud-archive/documentation#4422
This PR: