Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only][ci] dont run acceptance tests on CI after merge #902

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 30, 2020

related owncloud/QA#648

dont run acceptance tests on ci after merge
Also fix coverage reporting in sonarcloud analysis

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks too easy to do.

@dpakach dpakach force-pushed the change-ci-after-merge branch 9 times, most recently from 88691fb to 5900eec Compare November 30, 2020 09:20
@phil-davis
Copy link
Contributor

@dpakach I merged #903 so you get conflicts here - sorry.

@phil-davis
Copy link
Contributor

I merged #904 so this needs another rebase.

@dpakach dpakach force-pushed the change-ci-after-merge branch 3 times, most recently from 4a70b1f to 437feb8 Compare December 1, 2020 03:29
@dpakach dpakach closed this Dec 1, 2020
@dpakach dpakach reopened this Dec 1, 2020
@phil-davis
Copy link
Contributor

phil-davis commented Dec 1, 2020

Looks good now. After CI finishes we can merge. Then copy the latest starlark code to contacts and data_exporter apps, and that should fix the coverage %age there also.

I will try with search_elastic to see that all this new starlark code works there.

@phil-davis phil-davis merged commit 14a6a16 into master Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the change-ci-after-merge branch December 1, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants