Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop execution in case the script is used for an upgrade #11

Merged
merged 1 commit into from
Feb 18, 2015

Conversation

LukasReschke
Copy link
Member

Also includes new dependencies

Fixes #9

@karlitschek @PVince81

Also includes new dependencies

Fixes #9
@karlitschek
Copy link
Contributor

👍 Also thanks for the other improvements

LukasReschke added a commit to owncloud/core that referenced this pull request Sep 15, 2014
LukasReschke added a commit to owncloud/core that referenced this pull request Sep 16, 2014
@LukasReschke
Copy link
Member Author

@karlitschek Can we merge this and put live? We get again a lot of those bug reports, just now: owncloud/core#14317


// do we have PHP 5.3.3 or newer?
if(version_compare(PHP_VERSION, '5.3.3', '<')) {
$error.='PHP 5.3.3 is required. Please ask your server administrator to update PHP to version 5.3.3 or higher.<br/>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.4 ????

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still ship 7.0 with the installer as far I know

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

could you provide the instructions to compile owncloud client for Windows on sure 13?

Sent from Yahoo Mail on Android

From:"Lukas Reschke" notifications@github.com
Date:Wed, Feb 18, 2015 at 12:28 PM
Subject:Re: [administration] Stop execution in case the script is used for an upgrade (#11)

In web-installer/setup-owncloud.php:

  • @return string with error messages > */ > static public function checkdependencies() { > - $error=''; > - > - // do we have PHP 5.3.2 or newer? > - if(version_compare(PHP_VERSION, '5.3.2', '<')) { > - $error.='PHP 5.3.2 is required. Please ask your server administrator to update PHP to version 5.3.2 or higher. PHP 5.2 is no longer supported by ownCloud and the PHP community.'; > + $error = ''; > + $missingDependencies = array();; > + > + // do we have PHP 5.3.3 or newer? > + if(version_compare(PHP_VERSION, '5.3.3', '<')) { > + $error.='PHP 5.3.3 is required. Please ask your server administrator to update PHP to version 5.3.3 or higher.
    ';

We still ship 7.0 with the installer as far I know


Reply to this email directly or view it on GitHub.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide the instructions to compile owncloud client for Windows on sure 13?

Not really… This discussion is about something completely different, see #11 (comment)

@DeepDiver1975
Copy link
Member

👍

DeepDiver1975 added a commit that referenced this pull request Feb 18, 2015
Stop execution in case the script is used for an upgrade
@DeepDiver1975 DeepDiver1975 merged commit 338108a into master Feb 18, 2015
@DeepDiver1975 DeepDiver1975 deleted the addUpdateWarning branch February 18, 2015 22:48
@DeepDiver1975
Copy link
Member

@karlitschek @tomneedham how do we update this script on https://owncloud.org/install/#instructions-web ??? THX

@tomneedham
Copy link

@LukasReschke
Copy link
Member Author

So somebody (most likely @karlitschek) has to replace https://download.owncloud.com/download/community/setup-owncloud.php then ;-)

@DeepDiver1975
Copy link
Member

hmm - what about pointing the link to the admin repo?

@LukasReschke
Copy link
Member Author

hmm - what about pointing the link to the admin repo?

I'd avoid that as about 280 people can commit directly here… Would be way too easy to lure them into a botnet that way :)

@karlitschek
Copy link
Contributor

i will replace it in our server later. thanks guys

@karlitschek
Copy link
Contributor

This is now life. Thank you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setup-owncloud warning about not updating
5 participants