Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Improve UI design for passcode screen #3516

Closed
8 of 13 tasks
JuancaG05 opened this issue Jan 24, 2022 · 2 comments · Fixed by #3582
Closed
8 of 13 tasks

[FEATURE REQUEST] Improve UI design for passcode screen #3516

JuancaG05 opened this issue Jan 24, 2022 · 2 comments · Fixed by #3582

Comments

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Jan 24, 2022

The passcode screen is a bit outdated in UI terms, so it would be great to perform a design improvement on it. Some mockups will be created so that we can compare among the current design and several proposals, also trying to align design with iOS.

TASKS

  • Research (if needed)
  • Create mockups
  • Create branch feature/passcode_screen
  • Development tasks
    • Constraint layout
    • Implement numeric keyboard
    • Change passcode from Array to String
    • Remove attributes setters
    • Fit keyboard for all screen sizes
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/passcode_screen into master

PR

App: #3582
Library (if needed): Not needed for this issue

@tripplehay
Copy link

Sounds like a really good idea to me the passcode screen is outdated in aspect of designing.

@jesmrec jesmrec added this to the 2.21-next milestone Feb 4, 2022
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 21, 2022

Some examples of different existing styles:

iOS oC app nC Dropbox
Screen Shot 2022-02-21 at 14 13 35 Screenshot_20220221_145034 Screenshot_20220221_145537

@davcres davcres self-assigned this Mar 1, 2022
@davcres davcres linked a pull request Mar 11, 2022 that will close this issue
1 task
@jesmrec jesmrec added the Sprint label Mar 18, 2022
@fesave fesave removed the Sprint label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants