Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use user id not the displayname #839

Merged
merged 1 commit into from
Jan 8, 2018
Merged

use user id not the displayname #839

merged 1 commit into from
Jan 8, 2018

Conversation

DeepDiver1975
Copy link
Member

Fixes #836

@DeepDiver1975 DeepDiver1975 self-assigned this Dec 21, 2017
@DeepDiver1975 DeepDiver1975 mentioned this pull request Dec 21, 2017
Closed
@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented Dec 21, 2017 •
edited
Loading

For easy testing:
calendar.tar.gz

This was referenced Dec 21, 2017
Open
Open
Closed
Closed
@ittrend4710
Copy link

already tested it - see my remarks in #836

@coveralls
Copy link

coveralls commented Dec 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 54.965% when pulling a9b79e7 on bugfix/836 into b66a99e on master.

@DeepDiver1975 DeepDiver1975 merged commit 674e9e6 into master Jan 8, 2018
@DeepDiver1975 DeepDiver1975 deleted the bugfix/836 branch January 8, 2018 08:39
@localguru
Copy link

Doesn't work with 9.1.7 and calender 1.5.4. Ricardo665 #823 works, but I don't understand why?

@DeepDiver1975
Copy link
Member Author

Doesn't work with 9.1.7 and calender 1.5.4.

no new version of the calendar has been released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian1998 Julian1998 Awaiting requested review from Julian1998

Assignees

@DeepDiver1975 DeepDiver1975

Labels
3 - to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeepDiver1975 @ittrend4710 @coveralls @localguru