Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New folders should have vfs support available by default #6932

Closed
ckamm opened this issue Dec 19, 2018 · 4 comments
Closed

New folders should have vfs support available by default #6932

ckamm opened this issue Dec 19, 2018 · 4 comments
Assignees
Labels
Design & UX Enhancement feature:vfs native virtual files and placeholder implementation
Milestone

Comments

@ckamm
Copy link
Contributor

ckamm commented Dec 19, 2018

Currently new folders have no vfs support enabled unless it's explicitly switched on during folder creation. That means one needs to edit the config file to enable it later.

  • New folders should default to the best availabe vfs mode, but with the root folder starting out "available locally". Or Vfs::Off should migrate to the best available vfs mode once the first item is unpinned by the user?
  • There should be a way to move between vfs modes?
  • What does this mean for selective sync?

@michaelstingl fyi

@ckamm ckamm added Enhancement Design & UX feature:vfs native virtual files and placeholder implementation labels Dec 19, 2018
@ckamm ckamm added this to the 2.6.0 milestone Dec 19, 2018
@ckamm ckamm self-assigned this Dec 19, 2018
@ckamm ckamm changed the title New folders should have vfs support enabled New folders should have vfs support available by default Dec 19, 2018
@ckamm
Copy link
Contributor Author

ckamm commented Dec 21, 2018

Suggestions: @michaelstingl

  1. New folders start out with the best available vfs mode and the root as AvailableLocally by default.
  2. The wizard vfs setting just changes the root folder pin state to OnlineOnly instead.
  3. If any vfs mode is enabled (independent of pin state), selective sync is disabled.
  4. Old accounts without vfs enabled continue like that by default.
  5. Old accounts with suffix-vfs enabled are attempted to be migrated to better-vfs and stay suffix-vfs if it doesn't work.
  6. There's an option to switch on vfs for existing accounts where it's disabled.
  7. There probably should be an option to switch between vfs modes, in particular to off, so users can use selective sync again. Even though we might want to gradually deprecate selective sync.
  8. The wizard "choose what to sync" option sets up vfs pin states if vfs is available, not selective sync.

@ckamm
Copy link
Contributor Author

ckamm commented Dec 21, 2018

Speaking about selective sync: It'd make sense if features such as "don't automatically sync external storages" or "don't automatically sync folders with >100MB of contents" were available in the vfs world too.

@ckamm
Copy link
Contributor Author

ckamm commented Jan 9, 2019

PR #6954 already implements 3, 4, 5, 6, 7 (off only).

I don't think the remaining 1,2,8 should be done while vfs is considered experimental. That means the remainder of this ticket (new ticket?) should move to 2.7. @michaelstingl

@ckamm ckamm modified the milestones: 2.6.0, 2.7.0 Mar 13, 2019
@TheOneRing
Copy link
Member

Fixed in #8019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design & UX Enhancement feature:vfs native virtual files and placeholder implementation
Projects
None yet
Development

No branches or pull requests

2 participants