Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] active sync folder can be re-used with a different sync connection #8512

Closed
jnweiger opened this issue Mar 23, 2021 · 4 comments · Fixed by #8853
Closed

[QA] active sync folder can be re-used with a different sync connection #8512

jnweiger opened this issue Mar 23, 2021 · 4 comments · Fixed by #8853
Milestone

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Mar 23, 2021

Seen with client 2.7.7-rc2 on Linux Mint

  • connect ownCloud client to demo.owncloud.com
  • note the sync folder
  • connect testpilotcloud client to demo.owncloud.org, but specfy the sync folder of the other client.

image

  • Click "Connect". Two servers are now connected to the same folder.

Expected behaviour: The folder should be exclusive to the first client that connects. The connecting a second client should fail.

Multiple connections to the same folder is untested. Especially scary with VFS options.

@jnweiger
Copy link
Contributor Author

Same client can also connect the same user on the same server to the same folder a second time 🙈

@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 23, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2021

The issue was marked as stale for 7 days and closed automatically.

@github-actions github-actions bot closed this as completed May 1, 2021
@TheOneRing TheOneRing reopened this May 1, 2021
@TheOneRing TheOneRing removed the Stale label May 1, 2021
@TheOneRing TheOneRing added this to the 2.9.0 milestone May 1, 2021
@TheOneRing
Copy link
Member

We don't handle branding names in the current code

QString FolderMan::checkPathValidityForNewFolder(const QString &path, const QUrl &serverUrl) const

I guess we need to come up with a different detection mechanism.

@TheOneRing TheOneRing linked a pull request Aug 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants