-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard: Move the 'Skip folder configuration' in a radio button #6470
Conversation
Can a native speaker say if "Manually create custom synchronization folders" is good wording? |
@guruz "Manually create synchronization folders" - I think I'd leave out the "custom". |
@ogoffart also we use 'sync folder' everywhere not 'synchronization folder'. |
Not really. The button in the UI is "Folder Sync Connection" which would be improved. |
Maybe this? |
So the choice is between Let's wait for @settermjd as tie breaker? |
Vote for: Manually create sync folders |
I will not be offended - either is fine for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, just needs the wording change
5a13ef3
to
7b0a04f
Compare
Sounds good.. |
Since it’s now a lot of options, it’s probably also good to add »(recommended)« behind the first option, in addition of having it as default. Otherwise it’s very overwhelming for less technical people. (Which was the reason for not having so many there in the first place. ;) |
As a "less technical people" person, I like that suggestion! |
@jancborchardt Good idea, PR here #6534 |
Issue #3664
The goal is to make it more visible than the button.
An alternative would have been to simply rename the button to "Manual folder configuration", but I feel a radio button works better.
Here is how it looks:
cc/ @michaelstingl