Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Move the 'Skip folder configuration' in a radio button #6470

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

ogoffart
Copy link
Contributor

Issue #3664

The goal is to make it more visible than the button.
An alternative would have been to simply rename the button to "Manual folder configuration", but I feel a radio button works better.

Here is how it looks:
screenshot_20180419_141805

cc/ @michaelstingl

@guruz guruz added this to the 2.5.0 milestone Apr 19, 2018
@guruz
Copy link
Contributor

guruz commented Apr 19, 2018

Can a native speaker say if "Manually create custom synchronization folders" is good wording?
@settermjd @phil-davis @konisolde ?
Maybe it should say "individual" instead of "custom" and/or remove the "Manual"? Or add a "later" since it will be done in another wizard (just the account gets added with this option)

CC @michaelstingl @pmaier1

@konisolde
Copy link

@guruz "Manually create synchronization folders" - I think I'd leave out the "custom".

@guruz
Copy link
Contributor

guruz commented Apr 19, 2018

@ogoffart also we use 'sync folder' everywhere not 'synchronization folder'.

@ogoffart
Copy link
Contributor Author

also we use 'sync folder' everywhere not 'synchronization folder'.

Not really. The button in the UI is "Folder Sync Connection" which would be improved.
We probably should rename the other location "synchronization": It is not so good to use abbreviations.

@phil-davis
Copy link
Contributor

Synchronize everything from server (27 MB)
Choose what to sync
Create synchronization folders later
Create placeholders instead of downloading files (experimental)

Maybe this?
@settermjd

@guruz
Copy link
Contributor

guruz commented Apr 19, 2018

So the choice is between
Manually create sync folders
and
Create sync folders later
(So far we use sync folder and not synchronization foldereverywhere and I'm sure there was a reason for this, so we keep it. Dropbox does the same)

Let's wait for @settermjd as tie breaker?

@konisolde
Copy link

Vote for: Manually create sync folders

@phil-davis
Copy link
Contributor

I will not be offended - either is fine for me.

Copy link
Contributor

@ckamm ckamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, just needs the wording change

@ogoffart
Copy link
Contributor Author

So from the feedback I decided to name it Manually create folder sync connections ("Folder Sync Connection" are the words we use everywhere and hence how it should be called.

I also added an explainatory tooltip which is shown then the mouse hover this item for some seconds.

screenshot_20180423_124102

@guruz
Copy link
Contributor

guruz commented Apr 23, 2018

Sounds good..

@guruz guruz merged commit c1fb5e6 into master Apr 23, 2018
@guruz guruz deleted the skipfolderconfig branch April 23, 2018 11:29
@jancborchardt
Copy link
Member

Since it’s now a lot of options, it’s probably also good to add »(recommended)« behind the first option, in addition of having it as default. Otherwise it’s very overwhelming for less technical people. (Which was the reason for not having so many there in the first place. ;)

@konisolde
Copy link

As a "less technical people" person, I like that suggestion!

@ckamm
Copy link
Contributor

ckamm commented May 16, 2018

@jancborchardt Good idea, PR here #6534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants