Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add a "(recommended)" to the main option #6534

Merged
merged 1 commit into from
May 17, 2018
Merged

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented May 16, 2018

@jancborchardt

This will lead to a double parenthesis: "(recommended) (124 MB)". It'd be easy to make it say "(recommended, 124 MB)" if that seems better. (note that the size is not always available)

For #6470

@ckamm ckamm added this to the 2.5.0 milestone May 16, 2018
@ckamm ckamm self-assigned this May 16, 2018
@ckamm ckamm requested a review from guruz May 16, 2018 14:00
@ckamm ckamm merged commit ad5fbfe into 2.5 May 17, 2018
@ckamm ckamm deleted the add-recommened-text-6470 branch May 17, 2018 11:14
@jancborchardt
Copy link
Member

@ckamm putting it in only one parentheses would be nice and simpler, yes! :) Also not sure if this is standard, but what might be nice in addition is to bold that default entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants