Ensure we have a window to receive the nativeEvents #9219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/fix_close
branch
from
2a5ccc2
to
1a88d50
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Nov 16, 2021
| #elif defined(Q_OS_WIN) && QT_VERSION < QT_VERSION_CHECK(6, 0, 0) | ||
| // ensure we create a native window in order to receive nativeEvents | ||
| // by default this is only called on show | ||
| create(); |
There was a problem hiding this comment.
Have you checked the behavior with Qt6?
There was a problem hiding this comment.
I just did, the create is needed there too.
Co-authored-by: Dominik Schmidt <dschmidt@owncloud.com>
dschmidt
requested changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8979