Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we receive WM_ENDSESSION #9220

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Ensure we receive WM_ENDSESSION #9220

merged 2 commits into from
Nov 17, 2021

Conversation

TheOneRing
Copy link
Member

No description provided.

@TheOneRing TheOneRing requested a review from a team November 17, 2021 10:30
@TheOneRing
Copy link
Member Author

Alternative implementation to #9219

@dschmidt
Copy link
Member

One hundred gazillion lines vs. one line? :-D

@TheOneRing TheOneRing force-pushed the work/fix_close2 branch 2 times, most recently from 22508e1 to 13cdba9 Compare November 17, 2021 10:48
@TheOneRing
Copy link
Member Author

One hundred gazillion lines vs. one line? :-D

Yes I don't like it either but we can assume what happens in here.
I have no idea whether create() has any unexpected sideeffects...

@dschmidt
Copy link
Member

I guess create() is fine, but handling QUERYENDSESSION and ENDSESSION more correctly is what convinces me more of this version.

@TheOneRing
Copy link
Member Author

The fact that the ci is stuck in tests since 20min tells me that I need to have another look.
❤️ ci

@TheOneRing TheOneRing force-pushed the work/fix_close2 branch 2 times, most recently from c7b8f7e to f2b959a Compare November 17, 2021 11:51
@TheOneRing TheOneRing linked an issue Nov 17, 2021 that may be closed by this pull request
Client not always stops when requested by Windows #8979
Closed
@TheOneRing TheOneRing mentioned this pull request Nov 17, 2021
Closed
@TheOneRing
Create our own message loop to receive WM_ENDSESSION
64fffa3 
This ensures we receive the message even if no window is shown
@TheOneRing
Copy link
Member Author

Now we have an unrelated segfault in a unittest on mac

@TheOneRing TheOneRing merged commit 36311b0 into 2.9 Nov 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/fix_close2 branch November 17, 2021 13:50
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjv erikjv erikjv approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client not always stops when requested by Windows
3 participants
@TheOneRing @dschmidt @erikjv