Fix loading spinner with usernames containing spaces. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 12.15% (diff: 100%)@@ master #502 diff @@
==========================================
Files 47 47
Lines 831 831
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 101 101
Misses 730 730
Partials 0 0
|
|
Yes, it works! Thanks a lot! :-) |
|
👍 |
irgendwie
force-pushed
the
username-with-spaces
branch
from
c813ad7
to
9f80768
Compare
This was referenced Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should solve the issue with blanks in OC/NC usernames:
#430 - @AndrzejMM @ossadmirer314 @JSoko @DeepDiver1975
The bug is caused by not escaping urls in the dav lib.
This is a temporary fix, since we are switching to another dav lib anyway: #216