Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable preview path #23143

Closed
MorrisJobke opened this issue Mar 11, 2016 · 6 comments
Closed

Configurable preview path #23143

MorrisJobke opened this issue Mar 11, 2016 · 6 comments

Comments

@MorrisJobke
Copy link
Contributor

MorrisJobke commented Mar 11, 2016

  • like the path of the cache folder:
    /**
    * Location of the cache folder, defaults to ``data/$user/cache`` where
    * ``$user`` is the current user. When specified, the format will change to
    * ``$cache_path/$user`` where ``$cache_path`` is the configured cache directory
    * and ``$user`` is the user.
    */
    'cache_path' => '',

Background:

Often the user data is stored on a different storage server and it makes the access to those often needed files faster, because they are on the same server. Also it makes the redundancy easier. Those files are not that critical if they get lost and could be easily re-generated. Therefore it makes sense to put them on a storage that is not that redundant available but a lot faster to access.

cc @MTRichards for this feature request (was requested as a side note in a blue ticket)

cc @oparoz @icewind1991 for the implementation details - it shouldn't be that hard, or am I wrong here?

@oparoz
Copy link
Contributor

oparoz commented Mar 11, 2016

First thoughts:

If that's not a good solution, then much more work would be required from my pov because Preview is still using \OC\Files\View ($this->userView->mkdir($this->getThumbnailsFolder() . '/');) instead of the Node API.
So the best thing would be to first move it to the AppFramework #13610, but that issue is a year old and of low priority. That will never happen, but the move for preview generation from ajax to dav may trigger some Preview refactoring.

@oparoz
Copy link
Contributor

oparoz commented Mar 11, 2016

Thinking about it some more, just changing the path in Preview to make it a subfolder of cache will also have problems linked to the fact that Preview is still using \OC\Files\View...

@PVince81
Copy link
Contributor

discussed separating metadata from files here #18029

@PVince81
Copy link
Contributor

and #28939

@PVince81
Copy link
Contributor

closing in favor of #19548

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants