-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider new DAV endpoint for public shares #23269
Comments
cc @karlitschek @DeepDiver1975 @icewind1991 Thoughts? |
@LukasReschke Thanks! |
Maybe fixed by #24354 |
I believe that this will still not solve the problem completely as it will still exist for password protected files. We can't rely on the system sending cookies 🙈 |
@michaelstingl Next steps? If this is green, then please provide a proper Milestone |
For video in Safari, it has been solved with #24750 . |
The Webdav endpoint "public.php/webdav" is already used for public links in the web UI and seems to work fine so far even with link passwords. Maybe browsers are modern enough now ? A few operations like file download is still going back to the ajax endpoint currently because opening the link in a separate window caused trouble: #22297 |
In general we still need to provide a "new DAV" endpoint for public links to be able to support web UI chunking, so let's keep this ticket open to discuss how to achieve this. Maybe we should have a similar tree like "remote.php/dav/*" but in public: So we could have: "public.php/dav/share-links/$tokenId/path/to/file.txt". Would still require some kind of basic auth and cookies... Or we make "remote.php" support different auths (even no auth) on specific subpaths so we don't need "public.php" any more... More risky though as we need to make sure the Sabre auth plugins properly apply to DAV subpaths. Current public.php has its own Sabre server. For now I rather tend to the "public.php/dav" solution. |
WIP PR here: #29369 |
Stuff like
http://b378zUCKQ3G9vn4:dummypassword@localhost/oc/public.php/webdav
is not going to work in many browsers.This prevents us to use WebDAV for some parts of ownCloud. For example the public view as can be seen at owncloud/files_videoplayer#41 (comment)
My idea would here to have something like
public.php/share/$SHAREID/
so that no Basic Auth is required anymore. (password can still be provided but general authentication happens via session there)The text was updated successfully, but these errors were encountered: