Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double slash in URL makes trouble #30846

Closed
individual-it opened this issue Mar 21, 2018 · 4 comments
Closed

double slash in URL makes trouble #30846

individual-it opened this issue Mar 21, 2018 · 4 comments
Assignees

Comments

@individual-it
Copy link
Member

Steps to reproduce

  1. install owncloud
  2. make a request with an extra / in the path e.g. curl -u admin:admin http://localhost/ocs//v1.php/cloud/capabilities

Expected behaviour

owncloud should ignore that extra slash

Actual behaviour

empty answer

Server configuration

Operating system:
Ubuntu 17.10
Web server:
Apache2
Database:
Sqlite
PHP version:
7.1
ownCloud version: (see ownCloud admin page)
10.1 prealpha
Updated from an older ownCloud or fresh install:
fresh
Where did you install ownCloud from:
git

Logs

ownCloud log (data/owncloud.log)

{"reqId":"m35gCX069ytbtcuGbHbQ","level":3,"time":"2018-03-21T03:37:39+00:00","remoteAddr":"127.0.0.1","user":"--","app":"PHP","method":"GET","url":"\/ocs\/\/v1.php\/cloud\/capabilities","message":"Exception: The requested uri(\/ocs\/v1.php\/cloud\/capabilities) cannot be processed by the script '\/ocs\/\/v1.php') at \/home\/artur\/www\/owncloud-core\/lib\/private\/AppFramework\/Http\/Request.php#663"}
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #17384 (Double slash in URL gives error page), #9881 (Double-slash at URL root breaks browsing into subdirectories), #20922 (Logout URL missing trailing slash), #9064 (owncloudcmd is doubling URL in request), and #13326 (Make "Download from URL" configurable).

@phil-davis
Copy link
Contributor

This was noticed during some automated acceptance test work, and would be handy to fixup in general so that "people" can build up URL paths without worrying about which bits have / already on the end or at the beginning. If the resulting path has "go nowhere" // then ownCloud still copes.

@individual-it
Copy link
Member Author

fixed by #30848

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants