Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: overriding is broken for gif images #31804

Closed
VicDeo opened this issue Jun 15, 2018 · 8 comments · Fixed by #31990
Closed

Theming: overriding is broken for gif images #31804

VicDeo opened this issue Jun 15, 2018 · 8 comments · Fixed by #31990
Assignees
Milestone

Comments

@VicDeo
Copy link
Member

VicDeo commented Jun 15, 2018

  1. Enable theme-example
  2. Enable notifications app
  3. Set Mail Notifications in personal page to 'Notify about all events'
  4. php occ notifications:generate -u boo --link http://home.org go home!

Expected

Mail notification has logo-email.gif from theme-example

Actual

Mail notification has logo-email.gif from core

@michaelstingl
Copy link

@ChrisEdS FYI ^

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #3209 (Theming), #13402 (... broken), #20484 (Orientation for shared images broken), #31134 (Theming broken after trying to enabling a second theme), and #23569 (Theming image path).

@PVince81
Copy link
Contributor

affected version ? stable10 or 10.0.8 ? @VicDeo

@PVince81 PVince81 added this to the backlog milestone Jun 15, 2018
@VicDeo
Copy link
Member Author

VicDeo commented Jun 15, 2018

@PVince81 I got this with master and didn't test further. But I guess @ChrisEdS had the same with OC 10

@ChrisEdS
Copy link
Contributor

ChrisEdS commented Jun 16, 2018

Yes @VicDeo - I stumble upon this issue in 10.0.8

@VicDeo
Copy link
Member Author

VicDeo commented Jun 21, 2018

@PVince81 I'd like to start with this one for the next sprint
also it would include lib/private/URLGenerator.php refactoring for #31864

esimate: 1-1.5 md

@PVince81
Copy link
Contributor

@VicDeo is the refactoring included in your estimate ? Or just the bits from #31864 required for the fix ?

@VicDeo
Copy link
Member Author

VicDeo commented Jun 21, 2018

@PVince81 yes, refactoring of lib/private/URLGenerator.php (just one class) is included into estimate as I suspect it to be the case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants