Missing "Login failed" message when two factor app enabled

[PVince81]

Steps

1. Setup 10.0.10 RC1
2. Install and enable the dummy two factor app "twofactor_email"
3. Setup a new desktop client and enter valid credentials
4. The desktop client receives an error and "PasswordLoginForbidden" exception is logged
5. Check the logs for "Login failed" entries

Expected

One "Login failed" entry per PasswordLoginException entry.

Actual

No "Login failed".

Note: this message is usually used in fail2ban to detect failed login.
It was reported before that we wanted to have it in such scenarios, see #31909 for the "enforce token login" case where we added that.

Version

ownCloud 10.0.10 RC1

@DeepDiver1975 @cdamken

[ownclouders]

GitMate.io thinks possibly related issues are #31465 (Missing symfony event for failed login attempt), #18014 (Failed to login), #20659 (Missing singlequote for login failed log entry), #14232 (Enabling activity app fails), and #28070 (enable apps failed).

[PVince81]

something for @karakayasemi maybe ?

[karakayasemi]

👍 I will look at it.