Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated phpcs checks in drone for acceptance test code #32782

Closed
phil-davis opened this issue Sep 20, 2018 · 2 comments · Fixed by #32785
Closed

Add automated phpcs checks in drone for acceptance test code #32782

phil-davis opened this issue Sep 20, 2018 · 2 comments · Fixed by #32785

Comments

@phil-davis
Copy link
Contributor

The acceptance test code has been conforming to a proposed "standard" that was implemented some time ago but not formally enforced. It requires a bunch of PHP doc block standards, for example. See phpcs.xml in the root folder of the core repo.

The check is done with:

phpcs --standard=phpcs.xml tests/acceptance

Implement this much checking as a drone job, so that at least the acceptance test code stays to this standard.

Note: It is out-of-scope for this issue to decide what standard might apply to the whole code base and how to implement such a thing.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #32258 (Fix phpcs code style in acceptance tests), #31579 (test), #22485 (test), #22492 (test), and #32299 (Use --remote for acceptance tests run on drone).

@phil-davis phil-davis self-assigned this Sep 24, 2018
@phil-davis phil-davis mentioned this issue Sep 24, 2018
1 task
@phil-davis
Copy link
Contributor Author

PR #32785 implements this

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants