Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spaces at the end and the beginning of a filename are trimmed away for display #35017

Closed
individual-it opened this issue Apr 15, 2019 · 1 comment · Fixed by #39310
Closed
Labels

Comments

@individual-it
Copy link
Member

Steps to reproduce

  1. have a files called my file.txt (spaces at the beginning and the end of the name)

Expected behaviour

spaces are displayed in the UI

Actual behaviour

spaces are trimmed

image

data-file in the tr has the correct name but the content of <span class="nametext"> has the trimmed name

so we can end up with same looking file names in the folder
image

CC @phil-davis we have tests that do renames to names with trailing and leading spaces, they all pass nicely because we only check the data-file attribute of tr not the human readable name

@phil-davis
Copy link
Contributor

If innernametext has correct spaces before/after, then

  1. does the browser actually display any differently?
    (I suspect that the browser is not going to display "true" white space anyway)
  2. do the file names sort into "correct" order?
    (file names starting with spaces come first before those starting with a digit or letter)
  3. what is the display requirement when people put spaces at the start of a file name?
  4. white space at the end of a file name is not going to be visible anyway (unless there is an option to right-justify file names in the column), and does not effect sort order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants