-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview creation on external storages #5917
Comments
I think for phase 1 we can provide the option you mentionned. In phase 2 we can try and find out how many ext storage API could support streaming. |
CC @icewind1991 |
I think first we should drop the preview support for images/movies/etc for external storage and add an option to enable it. |
Agree with @kabum ! |
One question is also whether we consider a "Local" mount as an external storage. It goes through the same API, but its URL starts with "local::" |
"Local" should be the only exception for the preview renderer. Am I right? |
Yeah, I guess so. So the renderer should check whether the storage URL starts with "local::" or "home::" |
A switch for ext storage is the way to go: #12216 |
We can control preview generation per-storage now |
While looking at pull request #5882
I thought about what would happen if a user mounts an external storage with (many) movies? At least for some external storages (e.g. samba) this would mean that we would first download the complete movie before the preview can be created.
Maybe it would make sense to provide a config.php option to disable preview creation for external storages and maybe also a option to define a size limit. Desktop file managers provide similar options.
What do you think?
cc @kabum @Kondou-ger @georgehrke @PVince81
The text was updated successfully, but these errors were encountered: