Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview creation on external storages #5917

Closed
schiessle opened this issue Nov 18, 2013 · 9 comments
Closed

preview creation on external storages #5917

schiessle opened this issue Nov 18, 2013 · 9 comments

Comments

@schiessle
Copy link
Contributor

While looking at pull request #5882

I thought about what would happen if a user mounts an external storage with (many) movies? At least for some external storages (e.g. samba) this would mean that we would first download the complete movie before the preview can be created.

Maybe it would make sense to provide a config.php option to disable preview creation for external storages and maybe also a option to define a size limit. Desktop file managers provide similar options.

What do you think?

cc @kabum @Kondou-ger @georgehrke @PVince81

@PVince81
Copy link
Contributor

I think for phase 1 we can provide the option you mentionned.

In phase 2 we can try and find out how many ext storage API could support streaming.
If many, then we could add streaming support.
If almost none, abandon the idea.

@PVince81
Copy link
Contributor

CC @icewind1991

@MorrisJobke
Copy link
Contributor

I think first we should drop the preview support for images/movies/etc for external storage and add an option to enable it.

@etiess
Copy link

etiess commented Nov 18, 2013

Agree with @kabum !

@PVince81
Copy link
Contributor

One question is also whether we consider a "Local" mount as an external storage. It goes through the same API, but its URL starts with "local::"

@MorrisJobke
Copy link
Contributor

"Local" should be the only exception for the preview renderer. Am I right?

@PVince81
Copy link
Contributor

Yeah, I guess so. So the renderer should check whether the storage URL starts with "local::" or "home::"

@PVince81
Copy link
Contributor

PVince81 commented Dec 5, 2014

A switch for ext storage is the way to go: #12216

@RobinMcCorkell
Copy link
Member

We can control preview generation per-storage now

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants