do not load unnecessary code in case of webdav #19114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,6 +76,9 @@ class Server extends SimpleContainer implements IServerContainer { | |||
| /** @var string */ | |||
| private $webRoot; | |||
|
|
|||
| /** @var string */ | |||
| protected static $service = null; | |||
|
It would be better to defer the call to initTemplateEngine to whenever the first template is constructed so we do it on demand ( |
Closed
individual-it
added a commit
that referenced
this pull request
Sep 23, 2015
changing from "protected static" to "protected" as suggested by @nickvergessen #19114 (comment) moving initTemplate() into template constr. reduce to move initTemplate only cleanup spaces
|
closing in favor of #19293 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip loading stuff that is not needed for WebDAV