Move init template #19144
Closed
Move init template #19144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -668,14 +610,16 @@ public static function init() { | |||
| OC_User::setupBackends(); | |||
| } | |||
|
|
|||
| if (\OC::$server->getService() !== 'webdav') { | |||
There was a problem hiding this comment.
Better to leave these changes for a seperate PR and keep this PR for just the initTemplateEngine stuff
There was a problem hiding this comment.
yes - just because this check is kind of fragile - basically anything which is handled via remote.php can be treated as non template related execution
|
reduced to moving of initTemplateEngine() |
|
closing in favor of #19293 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving
initTemplateEngine()into the constructor of the template itself as proposed by @icewind1991#19114 (comment)