[stable10] tests async operations #32594

individual-it · 2018-09-05T11:47:38Z

Description

tests for #32414 (moving files using async operation)

one test depends on changed in the testing app owncloud/testing#21

Related Issue

Fixes API/Acceptance tests for Async Upload #32580

Motivation and Context

see issue

How Has This Been Tested?

🤖

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

PVince81 · 2018-09-10T14:15:55Z

tests/acceptance/features/bootstrap/WebDav.php

+		$stream = false;
+		if ($type === "asynchronously") {
+			$headers['OC-LazyOps'] = 'true';
+			if ($this->httpRequestTimeout > 0) {


does makeDavRequest read this attribute ?

having the server slow down could make some test wait forever when we don't want to wait

the slow-down need to be initialized by @Given the MOVE dav requests are slowed down by 10 seconds see slowdownDavRequests()
whatever the setting was before the test-run its set back to it by https://github.com/owncloud/core/pull/32594/files#diff-76a3f5f23003d99750d877daa045562aR2478

in these lines here we are only guessing that we need to set $stream=true. we need it because the server does not close the connection while its slowed down by the testing app but we need already some information from the header to do the next step.

PVince81

Looks good, apart from one concern: is there a situation where the tests would needlessly wait for the server ? Is the client able to kill the connection if it's stuck for expected X seconds ?

individual-it · 2018-09-10T14:31:31Z

If someone sets the setting needlessly the server would wait, but if the correct test steps are used it should not be a problem.
The client also can kill the connection by setting the timeout. e.g. with the Given the HTTP-Request-timeout is set to 5 seconds step

PVince81

Looks good.

See minor comment about utility method for config php settings

PVince81 · 2018-09-11T07:25:40Z

tests/acceptance/features/bootstrap/WebDav.php

+			)['stdOut'];
+			$this->oldAsyncSetting = \trim($oldAsyncSetting);
+		}
+		$this->runOcc(


did we not have utility methods yet for setting config.php settings ? perhaps we only had for oc_appconfig

there is no one yet, but definitely we should have one. proposing to make a new PR for that
issue opened #32666
should we have it in the coming sprint?

PVince81 · 2018-09-11T07:27:39Z

tests/acceptance/features/bootstrap/WebDav.php

+		if ($this->oldAsyncSetting === "") {
+			SetupHelper::runOcc(['config:system:delete', 'dav.enable.async']);
+		} elseif ($this->oldAsyncSetting !== null) {
+			SetupHelper::runOcc(


and here's the occ again, might be useful to have this in a utility method ? (if not too complex to add as it needs to be accessible from every context)

PVince81 · 2018-09-11T07:45:40Z

a wild conflict appears

codecov · 2018-09-11T07:46:16Z

Codecov Report

❗ No coverage uploaded for pull request base (stable10@9ec0907). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable10   #32594   +/-   ##
===========================================
  Coverage            ?   62.92%           
  Complexity          ?    18853           
===========================================
  Files               ?     1235           
  Lines               ?    73911           
  Branches            ?     1282           
===========================================
  Hits                ?    46511           
  Misses              ?    27020           
  Partials            ?      380

Flag	Coverage Δ	Complexity Δ
#javascript	`53.16% <ø> (?)`	`0 <ø> (?)`
#phpunit	`63.98% <ø> (?)`	`18853 <ø> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec0907...f4beb74. Read the comment docs.

individual-it · 2018-09-11T07:46:41Z

@PVince81 just killed that wild beast

PVince81

👍

phil-davis

It looks good. The little PHPdoc things could be fixed in a next PR, unless you can wait ffor another CI run before merging.

phil-davis · 2018-09-11T09:37:37Z

tests/acceptance/features/bootstrap/WebDav.php

@@ -1753,17 +1873,23 @@ public function userUploadsTheFollowingChunksUsingNewChunking($user, $file, Tabl
 	 *                            [0] the chunk number
 	 *                            [1] data content of the chunk
 	 *                            Chunks may be numbered out-of-order if desired.
-	 *
+	 * @package bool $async use asynchronous MOVE at the end or not


package or param ?

phil-davis · 2018-09-11T09:42:59Z

tests/acceptance/features/bootstrap/WebDav.php

@@ -2274,4 +2461,40 @@ public function userRestoresVersionIndexOfFile($user, $versionIndex, $path) {
 			['Destination' => $this->makeSabrePath($user, $path)]
 		);
 	}
+
+	/**
+	 * reset settings if there were set in the scenario


if they were set

individual-it · 2018-09-11T10:14:22Z

@phil-davis addressed your comments

phil-davis · 2018-09-11T10:17:04Z

👍
@PVince81 please merge when CI is happy.

phil-davis · 2018-09-11T14:42:49Z

Drone network errors - restarted.

PVince81 · 2018-09-11T20:53:41Z

restarted again

phil-davis · 2018-09-12T01:50:42Z

@PVince81 now it is ready for merge.

individual-it added 2 - Developing dev:acceptance-tests QA:team labels Sep 5, 2018

individual-it added this to the development milestone Sep 5, 2018

individual-it self-assigned this Sep 5, 2018

ownclouders mentioned this pull request Sep 5, 2018

async operation always returns HTTP code 202 #32598

Closed

individual-it force-pushed the stable10-testAsync branch 3 times, most recently from 33fe2dc to ad21a2d Compare September 6, 2018 17:28

individual-it changed the title ~~[WIP] [stable10] tests async operations~~ [stable10] tests async operations Sep 6, 2018

individual-it requested a review from phil-davis September 6, 2018 17:29

individual-it added 3 - To Review and removed 2 - Developing labels Sep 6, 2018

individual-it requested review from patrickjahns and PVince81 September 7, 2018 11:30

PVince81 reviewed Sep 10, 2018

View reviewed changes

PVince81 reviewed Sep 11, 2018

View reviewed changes

individual-it force-pushed the stable10-testAsync branch from ad21a2d to 1b5a2f0 Compare September 11, 2018 07:45

PVince81 approved these changes Sep 11, 2018

View reviewed changes

PVince81 added 4 - To release and removed 3 - To Review labels Sep 11, 2018

phil-davis approved these changes Sep 11, 2018

View reviewed changes

tests for async move

f4beb74

individual-it force-pushed the stable10-testAsync branch from 1b5a2f0 to f4beb74 Compare September 11, 2018 10:13

PVince81 merged commit ba827ea into stable10 Sep 12, 2018

PVince81 deleted the stable10-testAsync branch September 12, 2018 05:28

PVince81 mentioned this pull request Sep 13, 2018

10.0.10 - Changelog Test Results #32566

Closed

individual-it mentioned this pull request Sep 14, 2018

do not use stream to check file downloads #32703

Merged

10 tasks

phil-davis mentioned this pull request Oct 23, 2018

tests for async move #33274

Merged

PVince81 modified the milestones: development, QA Jan 11, 2019

lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable10] tests async operations #32594

[stable10] tests async operations #32594

individual-it commented Sep 5, 2018 •

edited

Loading

PVince81 Sep 10, 2018

individual-it Sep 10, 2018

PVince81 left a comment

individual-it commented Sep 10, 2018

PVince81 left a comment

PVince81 Sep 11, 2018

individual-it Sep 11, 2018

PVince81 Sep 11, 2018

PVince81 commented Sep 11, 2018

codecov bot commented Sep 11, 2018 •

edited

Loading

individual-it commented Sep 11, 2018

PVince81 left a comment

phil-davis left a comment

phil-davis Sep 11, 2018

phil-davis Sep 11, 2018

individual-it commented Sep 11, 2018

phil-davis commented Sep 11, 2018

phil-davis commented Sep 11, 2018

PVince81 commented Sep 11, 2018

phil-davis commented Sep 12, 2018

[stable10] tests async operations #32594

[stable10] tests async operations #32594

Conversation

individual-it commented Sep 5, 2018 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Open tasks:

PVince81 Sep 10, 2018

Choose a reason for hiding this comment

individual-it Sep 10, 2018

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

individual-it commented Sep 10, 2018

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 Sep 11, 2018

Choose a reason for hiding this comment

individual-it Sep 11, 2018

Choose a reason for hiding this comment

PVince81 Sep 11, 2018

Choose a reason for hiding this comment

PVince81 commented Sep 11, 2018

codecov bot commented Sep 11, 2018 • edited Loading

Codecov Report

individual-it commented Sep 11, 2018

PVince81 left a comment

Choose a reason for hiding this comment

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis Sep 11, 2018

Choose a reason for hiding this comment

phil-davis Sep 11, 2018

Choose a reason for hiding this comment

individual-it commented Sep 11, 2018

phil-davis commented Sep 11, 2018

phil-davis commented Sep 11, 2018

PVince81 commented Sep 11, 2018

phil-davis commented Sep 12, 2018

individual-it commented Sep 5, 2018 •

edited

Loading

codecov bot commented Sep 11, 2018 •

edited

Loading