-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for async move #33274
tests for async move #33274
Conversation
1ec2cf1
to
6fc9df1
Compare
Codecov Report
@@ Coverage Diff @@
## master #33274 +/- ##
============================================
- Coverage 64.06% 64.06% -0.01%
Complexity 18276 18276
============================================
Files 1190 1190
Lines 69048 69047 -1
Branches 1271 1271
============================================
- Hits 44235 44234 -1
Misses 24443 24443
Partials 370 370
Continue to review full report at Codecov.
|
@DeepDiver1975
This forward port has similar differences in expected status codes as you were experiencing when backporting "Introduce persistent and explicit locking of file and folders" |
I guess this issue was fixed and so the tests need to be adjusted #32598 |
I'm not aware of any change in this area .... |
Debugged it: this change in the behavior is because of the locking implementstion which was added to master and is now being backported to to stable10 in #33266 Some preconditions checks are now applied 'by accident' because we need to resolve the destination to get the locks. This can trigger already some early checks which causes non 202 responses. I think it's okay to adapt the acceptance criteria in here ... will take care |
@DeepDiver1975 great! Just push a commit onto this PR branch to adjust the expected results. Then we can look at what parts of this forward port need to be cherry-picked to the #33266 stable10 backport |
@DeepDiver1975 we only failed project codecov - lots of code added, all in You can override and merge this when you are happy. |
commit is cherry picked into #33266 |
Forward port #32594
Implements acceptance tests that (should) go with the forward port of code done in PR #32576