Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for async move #33274

Merged
merged 5 commits into from
Oct 25, 2018
Merged

tests for async move #33274

merged 5 commits into from
Oct 25, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 23, 2018

Forward port #32594

Implements acceptance tests that (should) go with the forward port of code done in PR #32576

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #33274 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33274      +/-   ##
============================================
- Coverage     64.06%   64.06%   -0.01%     
  Complexity    18276    18276              
============================================
  Files          1190     1190              
  Lines         69048    69047       -1     
  Branches       1271     1271              
============================================
- Hits          44235    44234       -1     
  Misses        24443    24443              
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (-0.01%) 18276 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
lib/public/Share.php 28.57% <0%> (ø) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57ac58...39f11fc. Read the comment docs.

@phil-davis
Copy link
Contributor Author

@DeepDiver1975
https://drone.owncloud.com/owncloud/core/11933/395

--- Failed scenarios:

    /drone/src/tests/acceptance/features/apiWebdavProperties/moveFileAsync.feature:139
    /drone/src/tests/acceptance/features/apiWebdavProperties/moveFileAsync.feature:149
/drone/src/tests/acceptance/features/apiWebdavProperties/moveFileAsync.feature:158

This forward port has similar differences in expected status codes as you were experiencing when backporting "Introduce persistent and explicit locking of file and folders"

@individual-it
Copy link
Member

I guess this issue was fixed and so the tests need to be adjusted #32598

@DeepDiver1975
Copy link
Member

I guess this issue was fixed and so the tests need to be adjusted #32598

I'm not aware of any change in this area ....

@DeepDiver1975
Copy link
Member

Debugged it: this change in the behavior is because of the locking implementstion which was added to master and is now being backported to to stable10 in #33266

Some preconditions checks are now applied 'by accident' because we need to resolve the destination to get the locks. This can trigger already some early checks which causes non 202 responses.

I think it's okay to adapt the acceptance criteria in here ... will take care

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 great! Just push a commit onto this PR branch to adjust the expected results.

Then we can look at what parts of this forward port need to be cherry-picked to the #33266 stable10 backport

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 we only failed project codecov - lots of code added, all in tests folder. I guess there are not tests for the tests :)

You can override and merge this when you are happy.

@DeepDiver1975 DeepDiver1975 merged commit 2a9e6f5 into master Oct 25, 2018
@DeepDiver1975 DeepDiver1975 deleted the testAsync-master branch October 25, 2018 06:41
@DeepDiver1975
Copy link
Member

commit is cherry picked into #33266

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants