Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password toggle login #4610

Merged
merged 2 commits into from Aug 28, 2013
Merged

Password toggle login #4610

merged 2 commits into from Aug 28, 2013

Conversation

jancborchardt
Copy link
Member

Currently the toggle is in 3 places, always for the password field:

  1. Installation page for choosing a password (and for the probably complex database password)
  2. Log in page for putting in your password
  3. Personal settings for changing a password (the »current password« field does not have it)

Now the installation page and the personal settings need this switch so you can double-check the password you just decided. But the log in page actually does not need it. So let’s just cut it there.

cc @raghunayyar @DeepDiver1975 @nono-gdv @kabum @karlitschek @MTRichards

@karlitschek
Copy link
Contributor

makes sense 👍

@MorrisJobke
Copy link
Contributor

@DeepDiver1975 Jenkins finished, but doesn't update https://ci.owncloud.org/job/pull-request-analyser/735/

👍

MorrisJobke added a commit that referenced this pull request Aug 28, 2013
@MorrisJobke MorrisJobke merged commit b9a95af into master Aug 28, 2013
@MorrisJobke MorrisJobke deleted the password-toggle-login branch August 28, 2013 13:04
@ghost
Copy link

ghost commented Aug 28, 2013

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/735/

@DeepDiver1975
Copy link
Member

@jancborchardt @karlitschek backport?

@MorrisJobke
Copy link
Contributor

I'm for a backport, because it solves the issue with 1password

@karlitschek
Copy link
Contributor

Yes please

@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants