Make the "show password" icon on the login page optional.

[nono-gdv]

This patch provides the basic functionality. I'm really not sure about the configuration part; this is just the best I could do.

Also, I'm not sure how to localize the strings I have added.

[ghost]

Can one of the admins verify this patch?

[Niduroki]

@jancborchardt @owncloud/designers

[MorrisJobke]

Why should this be configurable? Sorry, but I'm against this change

[nono-gdv]

The rationale is here: #4577

Basically, in our context, this is a security issue.

[DeepDiver1975]

@owncloud-bot this is okay to test

[DeepDiver1975]

@nono-gdv Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

[DeepDiver1975]

while is might be a configuration option (/me still no convinced) it is for sure nothing to be set on the admin page

[nono-gdv]

@DeepDiver1975 Well, the configuration interface is the part I struggled with. :-) I could very well do with a hidden option, be it configured in config.php or directly in the database (even though I'm not sure editing stuff directly in the database would be sane).

[MorrisJobke]

@nono-gdv A config option inside the config.php is fine. And please leave a comment in config.php.sample

[nono-gdv]

OK, I'm going to add the option to config.php.

[MorrisJobke]

Now you commit nothing (inside two commits ;)) Keep in mind, that this is your branch and you are therefore allowed to force push.

[nono-gdv]

Oops, I still have trouble with git and pull requests. :-) I am currently reworking the patch.

[nono-gdv]

This last version works for me; sorry about the clutter in git log.

Additionally I emailed the contributor agreement a few minutes ago.

[MorrisJobke]

Identation

[MorrisJobke]

@nono-gdv http://try.github.io/levels/1/challenges/1

@karlitschek Can you confirm this?

[karlitschek]

@kabum Confirmed :-)

[jancborchardt]

Sorry, but either we have this functionality in or we don’t. This is not something which should be configurable. So definitely 👎 for this specific pull request. Let’s find a better solution instead:

Currently the toggle is in 3 places, always for the password field:

1. Installation page for choosing a password (and for the probably complex database password)
2. Log in page for putting in your password
3. Personal settings for changing a password (the »current password« field does not have it)

Now the installation page and the personal settings need this switch so you can double-check the password you just decided. But the log in page actually does not need it. So let’s just cut it there.

Pull request upcoming.

[jancborchardt]

The pull request is at #4610. @nono-gdv does that solve the issue?

I’ll close this pull request here then – but thank you for bringing up the point again! And I hope the fix works for you. :)

[nono-gdv]

Simply removing the toggle from the login page is fine with me.

[jancborchardt]

@nono-gdv sweet! And the pull request was merged. Thanks again for your help! :)