This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Update LastLoginTimestamp when importing for a new user #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the LastLoginTimestamp when a user is created for an import.
That prevents later code from executing "first time login" actions for the user when they next log in.
The importer already does the needed stuff to set up the user's file system etc. We don't want later code to do "bonus" stuff, like copying in the skeleton.
A test scenario has been added to cover importing when a skeleton dir is defined on the system. While doing that, I also improved the test code - it was not actually deleting imported users at the end of the scenario, and the
simpleExport/userfoo
fixture was missing ashares.jsonl
file, which was causing the import to report a problem (but the files were being imported, so the existing tests were passing)Related Issue
Fixes #234
How Has This Been Tested?
Manually rerun the sequence in the issue and observe that the skeleton files have not been accidentally added to the user's files.
Types of changes
Checklist: