Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run testing against nightly tarball #74

Closed
wants to merge 1 commit into from

Conversation

patrickjahns
Copy link
Contributor

Motivation

should address failures in ui/api tests where the context of notifications app is missing

  `NotificationsContext` context class not found and can not be used.  

@phil-davis @individual-it - its a temporary fix - if we can enable/disable context per installed/available apps that is the favorable way to proceed ( I guess )

@patrickjahns patrickjahns self-assigned this Jun 1, 2018
@patrickjahns patrickjahns added this to the QA milestone Jun 1, 2018
@phil-davis
Copy link
Contributor

I guess there is nothing here like core drone.yml INSTALL_NOTIFICATIONS-APP which, as well as installing the app, enables it.

I suspect this will also be annoying when running core webUI tests locally - when running scenarios from webUISharingNotifications suite, notifications app needs to be enabled. When running other webUI tests, for some scenarios, it needs to be disabled.

The location of the notifications app enable/disable control needs to be thought through. Perhaps before/after scenario (or suite) methods could enable it for the things that need it. Then whatever runs those scenarios will get the needed app environment. @individual-it ?

@individual-it
Copy link
Member

general discussion about how to deal with apps in the acceptance tests here owncloud/QA#548
for notifications app we currently enable it by an env. variable https://github.com/owncloud/notifications/blob/master/.drone.yml#L71

@phil-davis
Copy link
Contributor

@patrickjahns I think we sorted files_primary_s3 CI against core QA tarballs now?
So this is old and can be closed.

@phil-davis
Copy link
Contributor

@patrickjahns this shows in my list of PRs waiting for review.
Is there anything to do here? Or close?

@PVince81
Copy link
Contributor

@phil-davis please make a decision. if the original issue from the OP "motivation" is obsolete then let's close ?

@PVince81 PVince81 assigned phil-davis and unassigned patrickjahns Feb 12, 2019
@phil-davis
Copy link
Contributor

We sorted out this stuff over the last months - acceptance test CI runs against both core master and stable10.

@phil-davis phil-davis closed this Feb 12, 2019
@phil-davis phil-davis deleted the drone_run_on_nightly branch February 12, 2019 15:07
@patrickjahns patrickjahns removed this from the development milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants