Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to private APIs (1 left!) #125

Closed
oparoz opened this issue Apr 20, 2015 · 2 comments
Closed

Remove calls to private APIs (1 left!) #125

oparoz opened this issue Apr 20, 2015 · 2 comments
Labels
blocked by core enhancement On hold

Comments

@oparoz
Copy link
Contributor

oparoz commented Apr 20, 2015

The app currently needs to use the following methods:

\OC_User::setIncognitoMode
\OC_Util::tearDownFS()
\OC_Util::setupFS()

Which make it non-compliant when tested with the app checker. (The original Pictures app is worst off)

It would be nice to be able to remove them at some point, but there is currently no viable alternatives available in the public namespace.

Should be fixed in 8.2 owncloud/core#4774
🙏

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@oparoz oparoz added the On hold label May 17, 2015
@oparoz
Copy link
Contributor Author

oparoz commented Jul 2, 2015

2 down, 1 left!
cb5994e

@oparoz oparoz changed the title Remove calls to private APIs Remove calls to private APIs (1 left!) Jul 11, 2015
@enoch85 enoch85 mentioned this issue Apr 14, 2015
Closed
@oparoz oparoz mentioned this issue Sep 4, 2016
Open
@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#28

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked by core enhancement On hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oparoz