Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

architecture: core apps should use OCP #4774

Closed
butonic opened this issue Sep 8, 2013 · 28 comments
Closed

architecture: core apps should use OCP #4774

butonic opened this issue Sep 8, 2013 · 28 comments
Labels
1 - To develop dev:ocp enhancement status/STALE technical debt
Milestone
maybe some day

Comments

@butonic
Copy link
Member

butonic commented Sep 8, 2013 •
edited by DeepDiver1975
Loading

OCP is the defacto API we expose to apps. In consequence the core apps should also use them.

@Kondou-ger @DeepDiver1975 @karlitschek @icewind1991 @bartv2 @schiesbn opinions?
@Niduroki
Copy link
Member

Niduroki commented Sep 8, 2013

👍 (since I "started" this discussion)

@butonic
Copy link
Member Author

butonic commented Sep 8, 2013

Actually deepdiver and I disussed 'everything is an app' already half a year ago. Core should be minimal and only manage oc apps. Consequently using OCP everywhere is just the first step...

@karlitschek
Copy link
Contributor

of course. Now we only need the time to extend the public api with all the needed calls and port all apps :-)

@DeepDiver1975
Copy link
Member

What about settings and user management?
Actually they are just apps as well right?
simplest agreement: one can build an app taking care of these functionalities.

@butonic
Copy link
Member Author

butonic commented Sep 8, 2013

guys relax. we have a lot more pressing matters but @Kondou-ger is right when he points out that I should either use OCP or internal calls. lets just decide on this. I vote for OCP.

@DeepDiver1975
Copy link
Member

For sure OCP 👍
Let me know as soon as public apis are missing I'll incorporate them in the public api branch

@jancborchardt
Copy link
Member

Is this solved, or technical debt? What’s the call on it @butonic @DeepDiver1975

@karlitschek
Copy link
Contributor

this is not resolved. Still an very important issue

@jancborchardt jancborchardt added this to the ownCloud 8 milestone Jul 16, 2014
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-next, ownCloud 8 Jan 9, 2015
@PVince81
Copy link
Contributor

@DeepDiver1975
Copy link
Member

Using the console command app:check-code this task is kind of easy

deepdiver@alien:~/Development/ownCloud/core [master]$ sudo -u www-data ./occ app:check-code files
ownCloud or one of the apps require upgrade - only a limited number of commands are available
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/appinfo/routes.php
 2 errors
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/appinfo/application.php
 2 errors
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/appinfo/remote.php
 2 errors
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/appinfo/register_command.php
 3 errors
    line    9: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/appinfo/app.php
 4 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/simplelist.php
 4 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/index.php
 9 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/tests/ajax_rename.php
 14 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/tests/helper.php
 14 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/tests/controller/apicontrollertest.php
 14 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/tests/service/tagservice.php
 19 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/list.php
 19 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/upload.php
 22 errors
    line    9: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/scan.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/getstoragestats.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/move.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/newfolder.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/list.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/rename.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/delete.php
 24 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/download.php
 25 errors
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/mimeicon.php
 26 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/ajax/newfile.php
 28 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/admin.php
 30 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_User - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/command/scan.php
 30 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_User - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/lib/activity.php
 30 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_User - static method call on private class
    line   50: OC_Util - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/lib/helper.php
 36 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/lib/capabilities.php
 36 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/lib/app.php
 36 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/controller/apicontroller.php
 36 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Files - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/download.php
 38 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_User - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/templates/simplelist.php
 38 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   46: OC_Util - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_Util - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_User - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/templates/appnavigation.php
 39 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   17: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/templates/index.php
 39 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   17: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/templates/list.php
 39 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   17: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/templates/admin.php
 39 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   17: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
Analysing /home/deepdiver/Development/ownCloud/core/apps/files/service/tagservice.php
 39 errors
    line    6: OC_Helper - static method call on private class
    line    9: OC_User - static method call on private class
    line   14: OC_User - static method call on private class
    line   15: OC_Helper - static method call on private class
    line   17: OC_Helper - static method call on private class
    line   19: OC_User - static method call on private class
    line   24: OC_Helper - static method call on private class
    line   25: OC_L10N - is instanciated
    line   29: OC_User - static method call on private class
    line   31: OC_Util - static method call on private class
    line   33: OC_Files - static method call on private class
    line   37: OC_Helper - static method call on private class
    line   37: OC_Files - static method call on private class
    line   44: OC_Util - static method call on private class
    line   46: OC_Util - static method call on private class
    line   46: OC_Helper - static method call on private class
    line   48: OC_User - static method call on private class
    line   49: OC_User - static method call on private class
    line   49: OC_Helper - static method call on private class
    line   49: OC_Util - static method call on private class
    line   50: OC_Util - static method call on private class
    line   51: OC_Helper - static method call on private class
    line   52: OC_User - static method call on private class
    line   53: OC_User - static method call on private class
    line   54: OC_Util - static method call on private class
    line   54: OC_Helper - static method call on private class
    line   69: OC_User - static method call on private class
    line   70: OC_API - used to fetch a const from
    line   70: OC_API - static method call on private class
    line   71: OC_User - static method call on private class
    line   77: OC_Helper - static method call on private class
    line   79: OC_User - static method call on private class
    line   80: OC_App - static method call on private class
    line   80: OC_User - static method call on private class
    line  109: OC_App - static method call on private class
    line  122: OC_Helper - static method call on private class
    line  155: OC_Helper - static method call on private class
    line  156: OC_Helper - static method call on private class
    line  187: OC_Helper - static method call on private class
App is not compliant
d

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-current, 8.2-next Mar 2, 2015
@rullzer
Copy link
Contributor

rullzer commented Apr 1, 2015

The following functions are used in the core apps. So we should expose them in a public API or have some alternatives.

Just some simple grepping gives me:

OC_Helper::computerFileSize
OC_Helper::findBinaryPath
OC_Helper::getFileNameMimeType
OC_Helper::getFileTemplateManager
OC_Helper::getMimeType
OC_Helper::getMimetypeDetector
OC_Helper::getSecureMimeType
OC_Helper::getStorageInfo
OC_Helper::humanFileSize
OC_Helper::linkTo
OC_Helper::linkToAbsolute
OC_Helper::linkToDocs
OC_Helper::linkToRemote
OC_Helper::linkToRoute
OC_Helper::mimetypeIcon
OC_Helper::tmpFile

OC_Util::addStyle
OC_Util::addVendorScript
OC_Util::addVendorStyle
OC_Util::checkAdminUser
OC_Util::checkLoggedIn
OC_Util::getUrlContent
OC_Util::isCallRegistered
OC_Util::isSharingDisabledForUser
OC_Util::obEnd
OC_Util::runningOnWindows
OC_Util::sanitizeHTML
OC_Util::setupFS
OC_Util::tearDownFS

Now some of those should be no problem to expose. Other however we might want to keep private.

@rullzer rullzer mentioned this issue Apr 1, 2015
Merged
@karlitschek
Copy link
Contributor

@rullzer I completely agree. They need to be exposed via OCP and kept stable.
Awesome initiative.

@rullzer
Copy link
Contributor

rullzer commented Apr 1, 2015

@karlitschek well it is trivial to move them to OCP. However, we need to discuss if we just want to move them as is. (so just a wrapper around the OC functions) or if we want to do some stuff differently and not expose the private stuff. Once they are in OCP we have to maintain them.

PR #15356 already removes some of the functions. We can then discuss how to handle the remaining ones.

Btw: when this is fixed we can also start working on #9078 to move to a better unit testable OC_Util and OC_Helper as long as we keep the public API stable.

@rullzer
Copy link
Contributor

rullzer commented Apr 1, 2015

Taken care of:

OC_Util::addStyle
OC_Util::isSharingDisabledForUser
OC_Helper::linkTo
OC_Helper::linkToAbsolute
OC_Helper::linkToRemote
OC_Helper::linkToRoute

Which leaves:

I propose to move (at least) the following functions to \OCP\Util:

  • OC_Helper::computerFileSize
  • OC_Helper::getFileNameMimeType
  • OC_Helper::getMimeType
  • OC_Helper::getSecureMimeType
  • OC_Helper::humanFileSize
  • OC_Helper::linkToDocs
  • OC_Helper::mimetypeIcon

Anymore? Suggetsions feedback? Else I'll just prepare a PR for this. They will be simple wrappers. But I guess we want to keep on exposing those anyway.

  • OC_Util::checkAdminUser
  • OC_Util::checkLoggedIn

Those should die, basically converting more stuff to the appframework should get rid of most of those already.

  • OC_Util::addVendorScript
  • OC_Util::addVendorStyle

There is already an issue #14111 for the first and by extend the second one.

For the remaining ones I have to dig a bit deeper. But suggestions and feedback are welcome on this.

@DeepDiver1975
Copy link
Member

I propose to move (at least) the following functions to \OCP\Util:

OC_Helper::computerFileSize
OC_Helper::getFileNameMimeType
OC_Helper::getMimeType
OC_Helper::getSecureMimeType
OC_Helper::humanFileSize
OC_Helper::linkToDocs
OC_Helper::mimetypeIcon

Anymore? Suggetsions feedback? Else I'll just prepare a PR for this. They will be simple wrappers. But I guess we want to keep on exposing those anyway.

We should create an interface \OCP\IUtil which defines the interface - this way we can increase testability

@DeepDiver1975
Copy link
Member

OC_Helper::linkToDocs

should go to the urlgenerator

@DeepDiver1975
Copy link
Member

OC_Helper::getMimeType
OC_Helper::getSecureMimeType
OC_Helper::mimetypeIcon

isnt there a class handling mime stuff?

@RobinMcCorkell
Copy link
Member

@DeepDiver1975 Indeed there is: \OC\Files\Type\Detection. But it doesn't handle mimetypeIcon - that's done in OC_Helper. Also, Detection hasn't got a public interface

I'd suggest providing an interface for OC\Files\Type\Detection, extending that class with the capability of mimetypeIcon, then exposing a \OCP\Util::getMimetypeDetector() or exposing that on the server container.

@rullzer
Copy link
Contributor

rullzer commented Apr 9, 2015

The OC_Response class is also used in several places. We do have \OCP\Response but that is missing the setStatus function (and the list of supported statuses).

What are the objections of having setStatus in OCP?

@rullzer rullzer mentioned this issue Apr 10, 2015
Merged
@RobinMcCorkell RobinMcCorkell mentioned this issue Apr 20, 2015
Closed
@MorrisJobke
Copy link
Contributor

@DeepDiver1975 I would say: Leave this in 8.2 or is this mandatory for 8.1?

@PVince81
Copy link
Contributor

If we start changing calls all over the place we'd probably need to do a full regression test. I'm not confident yet that unit tests would cover everything, so there is still a risk of breaking obscure cases.
I'd be more in favor of 8.2 to avoid the risk to compromise stability now (especially after feature freeze).

@rullzer
Copy link
Contributor

rullzer commented Apr 20, 2015

Wait until 8.2! Some stuff that needs to change is (unfortunately) non trivial. Rushing this now is sure to break stuff. Getting this done ASAP once 8.1 is released. For sure!

However, some of the PR's related to this could very well go into 8.1.

@MorrisJobke
Copy link
Contributor

Wait until 8.2! Some stuff that needs to change is (unfortunately) non trivial. Rushing this now is sure to break stuff. Getting this done ASAP once 8.1 is released. For sure!

Sure .... I was just confused by the milestone of the duplicate. ...I'm totally in with having all this for 8.2

@oparoz oparoz mentioned this issue Apr 21, 2015
Closed
@oparoz oparoz added the dev:ocp label Jun 25, 2015
@rullzer rullzer mentioned this issue Jul 25, 2015
Merged
4 tasks
@PVince81
Copy link
Contributor

We're past feature freeze and this is an ongoing task. Moving milestone to 9.0 to think about continuing it 😄

Would be good if someone could update the checkboxes.

@PVince81 PVince81 modified the milestones: 9.0-next, 8.2-current Sep 21, 2015
@DeepDiver1975 DeepDiver1975 mentioned this issue Oct 21, 2015
Closed
MorrisJobke added a commit that referenced this issue Nov 26, 2015
@MorrisJobke
Remove last occurences of OC_Helper::getMimeType()
9318606 
* ref #4774
@MorrisJobke MorrisJobke mentioned this issue Nov 26, 2015
Merged
@PVince81
Copy link
Contributor

Ongoing effort (we did make a bit of progress in 9.0) => 9.1

@PVince81 PVince81 modified the milestones: 9.1-next, 9.0-current Feb 12, 2016
@DeepDiver1975 DeepDiver1975 modified the milestones: 9.2-next, 9.1-current Jun 9, 2016
@oparoz oparoz mentioned this issue Sep 4, 2016
Open
@PVince81
Copy link
Contributor

still so much to do...

@PVince81 PVince81 modified the milestones: backlog, 10.0 Jan 27, 2017
@SamuAlfageme SamuAlfageme mentioned this issue Apr 30, 2018
Closed
@PVince81 PVince81 mentioned this issue Aug 28, 2018
Closed
@ownclouders ownclouders mentioned this issue Dec 16, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - To develop dev:ocp enhancement status/STALE technical debt
Projects
None yet
Milestone
maybe some day
Development

No branches or pull requests