Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Files" slideshow should better handle broken previews #47

Closed
oparoz opened this issue Feb 28, 2015 · 0 comments
Closed

The "Files" slideshow should better handle broken previews #47

oparoz opened this issue Feb 28, 2015 · 0 comments
Labels
Milestone

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 28, 2015

The files app is not telling plugins whether a preview is working or not, so we have to try to load it to see what happens.

If we encounter a broken preview, we should let the user know and remove it from the list of images for the currently loaded slideshow

A good test case is to enable the SVG provider. Most moderately complex SVGs won't have previews because the provider is crippled for security reasons.
The thumbnail should be blank and the slideshow will fail to get an image.

@oparoz oparoz added the bug label Feb 28, 2015
@oparoz oparoz closed this as completed Feb 28, 2015
oparoz added a commit that referenced this issue Mar 3, 2015
Introducing a notification area

Fix for #47
@oparoz oparoz added this to the 2.0.5 milestone Mar 4, 2015
@oparoz oparoz mentioned this issue Mar 8, 2015
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant