[fix/lock-bypass-prevention] Detect attempts to bypass a lock timeout by changing the clock #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- code cleanup (changing variable names, removing unnecessary self references and if let constructs, fix indentation, group code that belongs together, avoid repetitions) - move computation of lock timeout duration to lockTimeoutDuration property - add new methods to reset/start and remove the lock countdown - add new properties lockedSinceDate and lockedSinceSystemUptime to track the moment in time the lock timeout started - add new property timeHasBeenTamperedWith that uses lockedSinceDate and lockedSinceSystemUptime to determine if the clock time has been tampered with, a reboot has been performed, etc. - add new method that allows to check for clock time tampering and, if detected, reset the timer in a single call
|
|
10 tasks
…iled, would have prevented the significant time change notification from triggering a reset of the lock countdown
felix-schwarz
force-pushed
the
fix/lock-bypass-prevention
branch
from
99abf50
to
7dfd8cd
Compare
hosy
requested changes
Apr 24, 2024
… new one. The old one will be no longer fire and will be dropped from memory at that point.
hosy
approved these changes
Apr 24, 2024
|
Checks over the fix: After three failed attempts and locking condition:
With open keyboard
Checked other arbitrary cases, just to know if the brute force protection can be broken. Result is OK From my side this is approved @hosy @felix-schwarz |
jesmrec
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AppLockManagerRelated Issue
https://github.com/owncloud/security-tracker/issues/413
Screenshots (if appropriate):
Types of changes