Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/cardview-ui-refinement] Cardview UI Refinements #956

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Apr 27, 2021

Description

Made some UI refinements to the cardview controller:

  • fixed the corner radius (was gone in a version before)
  • for larger UI width set a maximum width for the cardview and center the view

Related Issue

Motivation and Context

UI Fetish

How Has This Been Tested?

  • open the more menu for an item
  • rotate the device
  • check on iPhone and iPad
  • on iPad place two windows side by side and change the window size and rotate the screen

Screenshots (if appropriate):

Simulator Screen Shot - iPad Air (4th generation) - 2021-04-27 at 13 28 29 Simulator Screen Shot - iPad Air (4th generation) - 2021-04-27 at 13 28 05
Simulator Screen Shot - iPad Air (4th generation) - 2021-04-27 at 13 30 07 Simulator Screen Shot - iPad Air (4th generation) - 2021-04-27 at 13 30 22
Simulator Screen Shot - iPhone 12 Pro Max - 2021-04-27 at 13 29 30 Simulator Screen Shot - iPhone 12 Pro Max - 2021-04-27 at 13 29 35

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

- fixed the corner radius (was gone in a version before)
- for larger UI width set a maximum width for the cardview and center the view
@hosy hosy self-assigned this Apr 27, 2021
@hosy hosy added this to the 11.6.0-Current milestone Apr 27, 2021
@hosy hosy requested a review from felix-schwarz April 27, 2021 13:54
@jesmrec
Copy link
Contributor

jesmrec commented Apr 27, 2021

QA

Checks done:

Rounded corners && card in:

  • iPhone portrait
  • iPhone landscape
  • iPad full screen portrait
  • iPad full screen landscape
  • iPad multi window portrait
  • iPad multi window landscape

this is approved for me.

Added the missing calens file

@jesmrec jesmrec added the Approved by QA Approved by QA label Apr 27, 2021
@hosy hosy merged commit 6d07286 into milestone/11.6 Apr 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/cardview-ui-refinement branch April 27, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants