Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty Spaces in Album Panel. #923

Closed
worksmarter opened this issue Nov 25, 2021 · 3 comments
Closed

Empty Spaces in Album Panel. #923

worksmarter opened this issue Nov 25, 2021 · 3 comments
Labels
Bug

Comments

@worksmarter
Copy link

Nextcloud version 22.2.1 or 22.2.2 update caused albums to be displayed with big spaces between some of them, particularly ones that have six songs in them push the lower albums out of the way and leave blank space in the albums panel. Also, the lack of tracks on an album seems to do the same thing. This occurred with an update to Nextcloud.

albums_one
album_two

.
@paulijar
Copy link
Collaborator

Thanks for the report. There seems to now be awfully much margin between the track names. Probably NC has changed some shared style definition and we now need to override it to get back to the intended layout.

@worksmarter
Copy link
Author

Thanks for the quick response. I would have to agree - those Nextcloud guys, not the music app - but the fix may have to be in the music app to override Nextclouds changes.

@paulijar paulijar added the Bug label Nov 26, 2021
paulijar added a commit that referenced this issue Nov 26, 2021
@paulijar
Fix layout problems on Nextcloud 22.2.1 and later
04b71cd 
The problems were most notable on the albums view using the "normal
layout" where the height of tracks shown by default exceeded the height
of the album art. This caused the total height of the album elements to
vary according the number of tracks on the album, and this in turn
caused unexpected empty "album slots" in the album flow.

The root cause of the problem was the new min-height set by NC on all
button elements. This indirectly increased the line height on the track
list and hence, the total height of the track list.

Another problem caused by the same root cause was that the confirm and
cancel buttons, shown e.g. when creating new playlist, were not round
but oval.

refs #923
@paulijar
Copy link
Collaborator

This is now fixed in Music v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulijar @worksmarter