Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] occ commands to handle OAuth2 features #94

Open
SamuAlfageme opened this issue Oct 13, 2017 · 5 comments
Open

[Feature Request] occ commands to handle OAuth2 features #94

SamuAlfageme opened this issue Oct 13, 2017 · 5 comments
Assignees

Comments

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Oct 13, 2017

Would be nice to include a few occ oauth: commands to handle some of the app's functions, e.g.

  • Set access_tokenexpiration time
  • Add/Generate a new Client (with/without explicit client_id/client_secret)
  • Revoke a session (not sure if possible with current implementation - i.e. only the user is able to do so from "Settings > Security")
  • ...
@IljaN
Copy link
Member

IljaN commented Dec 7, 2017

ilja@ilja-lap ~/c/core2> ./occ oauth2:create-client --help
Usage:
  oauth2:create-client [options]

Options:
  -U, --redirect-uri=REDIRECT-URI            Redirect Url
  -N, --name[=NAME]                          Name of the client [default: "a696a05e3d64"]
  -s, --allow-sub-domain[=ALLOW-SUB-DOMAIN]  Allow sub-domain [default: false]

Do we need a possibility to set identifier and secret? I would propose to leave them always auto generated for security reasons or else people will start to generate too short identifierts

@SamuAlfageme
Copy link
Contributor Author

Do we need a possibility to set identifier and secret?

I'd say yes, but no strong opinion. It makes easier to do #72 and avoid things like #73. To avoid them being too short we could force to be of a required length.

@Dagefoerde
Copy link

Dagefoerde commented Dec 8, 2017

I think you shouldn't be able to define secrets manually. In my opinion they should be completely random to have the most entropy.
Client ID doesn't really matter, it's transported openly in the URLs anyway, so user-defined strings may only cause problems if they contain very weird chars. Some simple validation might be sufficient here.

@IljaN
Copy link
Member

IljaN commented Dec 8, 2017

@Dagefoerde Yeah that was my concern, I think we will go the route of not allowing to manually define secrets whatsoever.

@cortho
Copy link

cortho commented Jan 24, 2018

@Dagefoerde, @IljaN I disagree.

When the ownCloud clients come with predefined, even hardcoded settings (see

private static $registry = [
) why shouldn't this be possible for users?

We would need this, for instance, for automated rollout of larger instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants