improve next #410
Merged
improve next #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add userlog_global_notifications_secret * add secrets for userlog * add secrets for userlog * add secret options * fix notifications secrets * fix notifications secrets * fix notifications secrets * add docs
12 tasks
wkloucek
force-pushed
the
improve-next
branch
from
8f02723
to
46e2bdd
Compare
kobergj
approved these changes
Oct 18, 2023
| # the path to the file containing the list of banned passwords | ||
| bannedPasswordsList: "" | ||
| # list of banned passwords | ||
| bannedPasswords: [] |
There was a problem hiding this comment.
Not sure if this will be sufficient in the future. I heard that there will be thousands of passwords in this banned password list. But we can iterate over this later
There was a problem hiding this comment.
I don't know where this should go. If we have thousands of passwords we might hit the ConfigMap size limit quite quickly.
But to be honest: is a list of thousands of passwords that is regularly updated still application configuration? I would rather thread this like eg. ClamAV virus signature databases... That need to be fetch from some sort of mirror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improve
nextbranchRelated Issue
nextbranch tracker for oCIS latest 5.0 compatiblity #406minCharacterssettingMotivation and Context
improve
nextHow Has This Been Tested?
bannedPasswordsand tested if they are enforcedScreenshots (if appropriate):
Types of changes
Checklist:
make docs) and committed