Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented deployment of suspended CronJobs #498

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Implemented deployment of suspended CronJobs #498

merged 5 commits into from
Mar 12, 2024

Conversation

d7oc
Copy link
Contributor

@d7oc d7oc commented Mar 11, 2024

Description

This PR implements issue 497. So CronJob will now be deployed all the time (if the corresponding service is enabled at all). Enabling the job in the values file will just switch if the CronJob is suspended or not.

Related Issue

Motivation and Context

Fixed issue 497

How Has This Been Tested?

Tested with helm template via

helm template --debug --set features.virusscan.enabled=true,services.storageusers.persistence.enabled=true,services.thumbnails.persistence.enabled=true,services.thumbnails.maintenance.cleanUpOldThumbnails.enabled=true,services.storageusers.maintenance.purgeExpiredTrashBinItems.enabled=true,services.storageusers.maintenance.cleanUpExpiredUploads.enabled=true,services.postprocessing.maintenance.restartPostprocessingVirusscan.enabled=true,services.postprocessing.maintenance.restartPostprocessingFinished.enabled=true myowncloud charts/ocis/.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@d7oc d7oc requested a review from wkloucek March 11, 2024 15:07
@d7oc d7oc added the Status:Needs-Review Needs review from a maintainer label Mar 11, 2024
@d7oc d7oc requested review from case0sh and nazliyanik March 11, 2024 15:07
@wkloucek wkloucek merged commit f2b2785 into next Mar 12, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the d7oc/issue497 branch March 12, 2024 08:03
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants